Add retry for ULN authentication #3892
Conversation
| Raises: | ||
| UlnCredentialsError: If all login attempts fail. | ||
| """ | ||
| for attempt in range(1, max_attempts + 1): |
There was a problem hiding this comment.
FWIW we do have the backoff crate for this which we already use in pulpcore: https://github.com/pulp/pulpcore/blob/139955c975af0c4bbaad2096f25808206b4d67a3/pulpcore/download/http.py#L250
With that said, this code isn't complex, I'm unsure whether we actually care to pull in a new dependency to the RPM plugin that may conflict with pulpcore at some point if we're not careful
Does the connection seem to drop specifically on the login attempt, but not during the downloads themselves? Or I suppose presumably the existing retry logic might be handling that.
There was a problem hiding this comment.
@ggainey Do you have an opinion. I'm a bit partial to leaving it as-is
There was a problem hiding this comment.
Also I would prefer to keep the default number of retries consistent with RpmRemote, so 4.
There was a problem hiding this comment.
Does the connection seem to drop specifically on the login attempt, but not during the downloads themselves? Or I suppose presumably the existing retry logic might be handling that.
Yes the connection drops on the login attempt. This happens a lot during a sync and will throw an error. Adding the login retry fixes the issue.
Also I would prefer to keep the default number of retries consistent with RpmRemote, so 4.
I can change this.
closes #3891